Re: [Qemu-devel] [PATCH 00/20] Block device mirroring enhancements, 12-12-12 edition

[Stefan Hajnoczi]

On Wed, Dec 12, 2012 at 02:46:19PM +0100, Paolo Bonzini wrote:
> Here are my block mirroring patches for QEMU 1.4, please review.
> 
> Patches 1-12 implement improvements and optimizations to the code
> that went in 1.3.

I had one question which may be a bug: I can't see anything that sets
s->in_flight_bitmap in Patches 1-12.  What am I missing.

Other comments were mainly cleanups.

If you don't see this until tomorrow I'll ping you on IRC tomorrow
morning.  Patches 1-12 are clean and I'd like to merge them for QEMU
1.4.

> Patches 13-20 (lacking tests for now) implement a persistent dirty
> bitmap.  The bitmap can be used to run storage migration jobs across
> multiple executions of the VM or, in the future, offline via qemu-img.

Please split Patches 13-20 into a separate "persistent dirty bitmap"
series.

Stefan