[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC V5 57/62] qcow2: Add qcow2_pause_dedup.
From: |
Benoît Canet |
Subject: |
[Qemu-devel] [RFC V5 57/62] qcow2: Add qcow2_pause_dedup. |
Date: |
Wed, 16 Jan 2013 16:48:36 +0100 |
---
block/qcow2-dedup.c | 19 +++++++++++++++++++
block/qcow2.c | 2 ++
block/qcow2.h | 1 +
3 files changed, 22 insertions(+)
diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
index dd320bf..e007387 100644
--- a/block/qcow2-dedup.c
+++ b/block/qcow2-dedup.c
@@ -1278,15 +1278,20 @@ static void
qcow2_deduplicate_after_resuming(BlockDriverState *bs)
BDRVQcowState *s = bs->opaque;
uint64_t i;
bool processed;
+ bool exit;
/* for each l2 entry */
for (i = 0; i < s->l2_size * s->l1_size; i++) {
qemu_co_mutex_lock(&s->lock);
processed = qcow2_process_to_dedup_cluster(bs, i);
+ exit = s->dedup_status == QCOW_DEDUP_STOPPING;
qemu_co_mutex_unlock(&s->lock);
if (processed || !(i % s->l2_size)) {
co_sleep_ns(rt_clock, s->dedup_co_delay);
}
+ if (exit) {
+ return;
+ }
}
}
@@ -1450,3 +1455,17 @@ void qcow2_dedup_update_metrics(BlockDriverState *bs)
s->dedup_metrics.ram_usage = nb_hashs * GTREE_NODE_SIZE * 2;
s->dedup_metrics.ram_usage += nb_hashs * sizeof(QCowHashNode);
}
+
+void qcow2_pause_dedup(BlockDriverState *bs)
+{
+ BDRVQcowState *s = bs->opaque;
+
+ if (s->dedup_status != QCOW_DEDUP_STARTED) {
+ return;
+ }
+
+ s->dedup_status = QCOW_DEDUP_STOPPING;
+ /* must handle half processed write requests */
+ qcow2_dedup_reset(bs);
+ s->dedup_status = QCOW_DEDUP_STOPPED;
+}
diff --git a/block/qcow2.c b/block/qcow2.c
index e442268..c17ab63 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -2011,6 +2011,8 @@ static BlockDriver bdrv_qcow2 = {
.bdrv_invalidate_cache = qcow2_invalidate_cache,
+ .bdrv_pause_dedup = qcow2_pause_dedup,
+
.create_options = qcow2_create_options,
.bdrv_check = qcow2_check,
};
diff --git a/block/qcow2.h b/block/qcow2.h
index d8e8539..5940c89 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@ -511,5 +511,6 @@ bool qcow2_dedup_is_running(BlockDriverState *bs);
int qcow2_dedup_init(BlockDriverState *bs);
void qcow2_dedup_close(BlockDriverState *bs);
void qcow2_dedup_update_metrics(BlockDriverState *bs);
+void qcow2_pause_dedup(BlockDriverState *bs);
#endif
--
1.7.10.4
- [Qemu-devel] [RFC V5 41/62] qcow2: Collect undeduplicated cluster metric., (continued)
- [Qemu-devel] [RFC V5 41/62] qcow2: Collect undeduplicated cluster metric., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 25/62] qcow2: Add verification of dedup table., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 39/62] qcow2: Collect unaligned writes missing data reads metric., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 59/62] qcow2: Make dedup status persists., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 21/62] qcow2: Remove hash when cluster is deleted., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 51/62] block: Add BlockDriver function prototype to pause and resume deduplication., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 37/62] qcow2: Add deduplication metrics structures., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 24/62] qcow2: Serialize write requests when deduplication is activated., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 26/62] qcow2: Adapt checking of QCOW_OFLAG_COPIED for dedup., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 40/62] qcow2: Collect deduplicated cluster metric., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 57/62] qcow2: Add qcow2_pause_dedup.,
Benoît Canet <=
- [Qemu-devel] [RFC V5 16/62] qcow2-cache: Allow to choose table size at creation., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 58/62] qcow2: Add qcow2_resume_dedup., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 60/62] qerror: Add QERR_DEVICE_NOT_DEDUPLICATED., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 28/62] qcow2: Do not overwrite existing entries with QCOW_OFLAG_COPIED., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 15/62] qcow2: Extract qcow2_do_table_init., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 43/62] qcow2: Count QCowHashNode removal from tree for metrics., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 23/62] qcow2: Integrate deduplication in qcow2_co_writev loop., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 14/62] qcow2: Load and save deduplication table header extension., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 13/62] qcow2: Create qcow2_is_cluster_to_dedup., Benoît Canet, 2013/01/16
- [Qemu-devel] [RFC V5 44/62] qcow2: Count cluster deleted metric, Benoît Canet, 2013/01/16