[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors |
Date: |
Thu, 17 Jan 2013 08:28:11 -0500 (EST) |
----- Original Message -----
> On 01/16/13 18:59, Alon Levy wrote:
> > Regarding orientation setting in windows 7 64 guest:
> > Desktop, right click->Screen resolution
> > - You can choose Orientation: Landscape, Portrait, Landscape
> > (flipped), Portrait (flipped)
> > - You can choose Resolution
> > - You can click "Advanced Settings", then "List All Modes" at the
> > bottom, you get all the modes (i.e. four of each resolution, one
> > for each orientation)
>
> Ah, ok. The driver seems to handle portrait and swap x+y when
> creating
> a displaysurface. At least I get a 600x800 display upright.
>
> I can't see a difference between Landscape + Landscape (flipped).
> Likewise Portrait + Portrait (flipped). Is there any?
>
> > There are two changes after applying the "change rom size to 8192"
> > patch:
> > - there is no longer an Orientation option
> > - the modes listed under "List All Modes" reduce as expected
>
> Ok, so we loose the Portrait mode.
>
> > Changes to the second patch:
> > - no orientations except the normal
>
> Keeping orientation 0+1 (and dropping the flipped 2+3 versions)
> should
> make the mode list small enougth that it fits while maintaining
> support
> for the portrait mode.
I'll test if this changes anything for a windows guest & linux guest.
>
> I think it would also be good to fix the driver to ignore everything
> with or
... what was the end of that sentence?
>
> How about that?
>
> > - hard code 8192 bytes rom size
> > - assert if the required size is larger
>
> Good.
>
> cheers,
> Gerd
>
>
>
- Re: [Qemu-devel] [PATCH 2/2] qxl: change rom so that 4096 < size < 8192, Alon Levy, 2013/01/15
- Re: [Qemu-devel] [PATCH 2/2] qxl: change rom so that 4096 < size < 8192, Gerd Hoffmann, 2013/01/15
- Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors, Alon Levy, 2013/01/21
- [Qemu-devel] [PATCH v3 1/2] qxl: stop using non revision 4 rom fields for revision < 4, Alon Levy, 2013/01/21
- [Qemu-devel] [PATCH v3 2/2] qxl: change rom size to 8192, Alon Levy, 2013/01/21
- Re: [Qemu-devel] [PATCH v3 2/2] qxl: change rom size to 8192, Markus Armbruster, 2013/01/22
- Re: [Qemu-devel] [PATCH v3 1/2] qxl: stop using non revision 4 rom fields for revision < 4, Alon Levy, 2013/01/21
- Re: [Qemu-devel] [PATCH v3 1/2] qxl: stop using non revision 4 rom fields for revision < 4, Gerd Hoffmann, 2013/01/21
- Re: [Qemu-devel] [PATCH v3 1/2] qxl: stop using non revision 4 rom fields for revision < 4, Markus Armbruster, 2013/01/22