[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 04/13] block: add snapshot info query functio
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V4 04/13] block: add snapshot info query function bdrv_query_snapshot_infolist() |
Date: |
Thu, 17 Jan 2013 14:53:35 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 01/17/2013 12:40 AM, Wenchao Xia wrote:
> This patch add function bdrv_query_snapshot_infolist(), which will
> return snapshot info of an image in qmp object format. The implementation
> code are mostly copied from qemu-img.c with modification to fit more
> for qmp based block layer API.
> To help filter out snapshot info not needed, a call back function is
> added in bdrv_query_snapshot_infolist().
> bdrv_can_read_snapshot() should be called before call this function,
> to avoid got *errp set unexpectly.
s/unexpectly/unexpectedly/
>
> Signed-off-by: Wenchao Xia <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> block.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> include/block/block.h | 7 +++++++
> 2 files changed, 53 insertions(+), 0 deletions(-)
>
> +SnapshotInfoList *bdrv_query_snapshot_infolist(BlockDriverState *bs,
> + SnapshotFilterFunc filter,
> + void *opaque,
> + Error **errp)
> +{
> + int i, sn_count;
> + QEMUSnapshotInfo *sn_tab = NULL;
> + SnapshotInfoList *info_list, *cur_item = NULL, *head = NULL;
> +
> + sn_count = bdrv_snapshot_list(bs, &sn_tab);
> + if (sn_count < 0) {
> + /* Fix me: set errp in bdrv_snapshot_list() instead of here */
You didn't remove this fixme anywhere in the series; it would be better
to respin things to avoid a net gain of fixmes.
> + error_setg(errp, "bdrv_snapshot_list: error %d\n", sn_count);
> + return NULL;
> + }
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V4 00/13] add qmp/hmp interfaces for snapshot info, Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 01/13] qemu-img: remove unused parameter in collect_image_info(), Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 02/13] block: add bdrv_get_filename() function, Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 03/13] block: add bdrv_can_read_snapshot() function, Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 04/13] block: add snapshot info query function bdrv_query_snapshot_infolist(), Wenchao Xia, 2013/01/17
- Re: [Qemu-devel] [PATCH V4 04/13] block: add snapshot info query function bdrv_query_snapshot_infolist(),
Eric Blake <=
- [Qemu-devel] [PATCH V4 05/13] block: add image info query function bdrv_query_image_info(), Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 06/13] qemu-img: switch image retrieving function, Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 07/13] block: rename bdrv_query_info to bdrv_query_block_info, Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 08/13] qmp: add interface query-images., Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 09/13] block: export function bdrv_find_snapshot(), Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 11/13] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 10/13] qmp: add interface query-snapshots, Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 12/13] hmp: switch snapshot info function to qmp based one, Wenchao Xia, 2013/01/17
- [Qemu-devel] [PATCH V4 13/13] hmp: show snapshots on single block device, Wenchao Xia, 2013/01/17