[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting |
Date: |
Mon, 21 Jan 2013 18:36:21 -0000 |
Hi,
Thank you for submitting your patch series. checkpatch.pl has
detected that one or more of the patches in this series violate
the QEMU coding style.
If you believe this message was sent in error, please ignore it
or respond here with an explanation.
Otherwise, please correct the coding style issues and resubmit a
new version of the patch.
For more information about QEMU coding style, see:
http://git.qemu.org/?p=qemu.git;a=blob_plain;f=CODING_STYLE;hb=HEAD
Here is the output from checkpatch.pl:
Subject: qom: remove object_delete
total: 0 errors, 0 warnings, 48 lines checked
Your patch has no obvious style problems and is ready for submission.
Subject: cpu: do not use object_delete
total: 0 errors, 0 warnings, 40 lines checked
Your patch has no obvious style problems and is ready for submission.
Subject: qdev: drop extra references at creation time
total: 0 errors, 0 warnings, 56 lines checked
Your patch has no obvious style problems and is ready for submission.
Subject: qdev: inline object_delete into qbus_free/qdev_free
total: 0 errors, 0 warnings, 18 lines checked
Your patch has no obvious style problems and is ready for submission.
Subject: qdev: add reference for the bus while it is referred to by the
DeviceState
total: 0 errors, 0 warnings, 15 lines checked
Your patch has no obvious style problems and is ready for submission.
Subject: qdev: move unrealization of devices from finalize to unparent
total: 0 errors, 0 warnings, 48 lines checked
Your patch has no obvious style problems and is ready for submission.
Subject: qdev: move deletion of children from finalize to unparent
WARNING: line over 80 characters
#35: FILE: hw/qdev.c:450:
+ assert(bus != sysbus_get_default()); /* main_system_bus is never freed
*/
total: 0 errors, 1 warnings, 59 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Regards,
Anthony Liguori
- Re: [Qemu-devel] [PATCH v2 03/12] qom: preserve object while unparenting it, (continued)
- [Qemu-devel] [PATCH v2 05/12] qdev: add reference count to a device for the BusChild, Paolo Bonzini, 2013/01/21
- [Qemu-devel] [PATCH v2 06/12] qdev: move deletion of children from finalize to unparent, Paolo Bonzini, 2013/01/21
- [Qemu-devel] [PATCH v2 07/12] qdev: move unrealization of devices from finalize to unparent, Paolo Bonzini, 2013/01/21
- [Qemu-devel] [PATCH v2 11/12] cpu: do not use object_delete, Paolo Bonzini, 2013/01/21
- [Qemu-devel] [PATCH v2 09/12] qdev: inline object_delete into qbus_free/qdev_free, Paolo Bonzini, 2013/01/21
- [Qemu-devel] [PATCH v2 04/12] qom: document reference counting of link properties, Paolo Bonzini, 2013/01/21
- [Qemu-devel] [PATCH v2 08/12] qdev: add reference for the bus while it is referred to by the DeviceState, Paolo Bonzini, 2013/01/21
- [Qemu-devel] [PATCH v2 10/12] qdev: drop extra references at creation time, Paolo Bonzini, 2013/01/21
- [Qemu-devel] [PATCH v2 12/12] qom: remove object_delete, Paolo Bonzini, 2013/01/21
- Re: [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting,
Anthony Liguori <=
- Re: [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting, Paolo Bonzini, 2013/01/25