Re: [Qemu-devel] [PATCH v2] vmware_vga: fix out of bounds and invalid rects updating

[BALATON Zoltan]

On Fri, 25 Jan 2013, Michael Tokarev wrote:
> But since vmsvga_update_rect() has other sanity checks already,
> I'm adding the missing ones there as well.
>
> Cc'ing BALATON Zoltan and Andrzej Zaborowski who shows in `git blame'
> output and may know something in this area.

I've proposed this patch before: http://patchwork.ozlabs.org/patch/197904/ 
but then thought that later commit 
4b4496dbccc5f286f0ef411f0ff702d67cb95145 fixed this and similar problems 
in other devices by clipping out of bounds updates further down the road 
so no further checks should be needed. There was some debate on where to 
put these checks but I'm not sure about the outcome so I'm not sure if we 
need more checks in devices now or not. I'm afraid I don't have more 
helpful information on this.

Regards,
BALATON Zoltan