|
From: | Kuo-Jung Su |
Subject: | Re: [Qemu-devel] [PATCH v2] target-arm: add Faraday ARMv5TE processors support |
Date: | Mon, 28 Jan 2013 15:19:45 +0800 |
On 25 January 2013 07:18, Kuo-Jung Su <address@hidden> wrote:I'm going to need pointers to the CPU documentation to be able
> From: Kuo-Jung Su <address@hidden>
>
> Faraday processors are a series of ARMv4/ARMv5TE clone.
>
> * ARMv4 series (FA526, FA626).
>
> All of them are now out-of-date, so I have no plan for them.
>
> * ARMv5TE series (FA606TE, FA626TE, FA616TE, FA726TE)
>
> All the single core RISC listed above are included in this patch.
> And there are two Faraday CP15 extensions (AUX and I/D-Scratchpad)
> have been implemented as a read/write value without any extra actions.
to review this patch, though it looks mostly ok.
One point: you've added new CPU state fields so you must add
save and restore code for them in target-arm/machine.c
(and increment CPU_SAVE_VERSION in target-arm/cpu.h.)
thanks
-- PMM
[Prev in Thread] | Current Thread | [Next in Thread] |