qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH qom-cpu for-1.4] target-arm: Rename CPU types


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH qom-cpu for-1.4] target-arm: Rename CPU types
Date: Tue, 29 Jan 2013 13:00:57 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2

Am 29.01.2013 12:03, schrieb Peter Maydell:
> On 27 January 2013 16:30, Andreas Färber <address@hidden> wrote:
>> In the initial conversion of CPU models to QOM types, model names were
>> mapped 1:1 to type names. As a side effect this gained us a type "any",
>> which is now a device.
>>
>> To avoid "-device any" silliness and to pave the way for compiling
>> multiple targets into one executable, adopt a <name>-<arch>-cpu scheme.
>> This leads to names like arm926-arm-cpu but is easiest to handle.
>>
>> No functional changes for -cpu arguments or -cpu ? output.
>>
>> Suggested-by: Eduardo Habkost <address@hidden>
>> Signed-off-by: Andreas Färber <address@hidden>
> 
> Acked-by: Peter Maydell <address@hidden>

I just re-reviewed this: env->cpu_model_str is set in cpu_arm_init(), so
this patch is good to go (unlike unicore32).

> I assume you're going to submit this via the qom subtree.

It applies to master now and is an arm-internal leaf patch. Since you
have another target-arm.next patch that Blue didn't pick up so far, feel
free to send a pull for both. But I'm fine taking it through my tree if
you prefer.

Thanks,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]