Re: [Qemu-devel] [PATCH 0/1] sclp default fix

[Anthony Liguori]

Hi,

Thank you for submitting your patch series.  This patch breaks the build
by causing make to fail.  Here's the output:

  GEN   i386-softmmu/config-devices.mak
  GEN   x86_64-softmmu/config-devices.mak
  GEN   alpha-softmmu/config-devices.mak
  GEN   arm-softmmu/config-devices.mak
  GEN   cris-softmmu/config-devices.mak
  GEN   lm32-softmmu/config-devices.mak
  GEN   m68k-softmmu/config-devices.mak
  GEN   microblaze-softmmu/config-devices.mak
  GEN   microblazeel-softmmu/config-devices.mak
  GEN   mips-softmmu/config-devices.mak
  GEN   mipsel-softmmu/config-devices.mak
  GEN   mips64-softmmu/config-devices.mak
  GEN   mips64el-softmmu/config-devices.mak
  GEN   or32-softmmu/config-devices.mak
  GEN   ppc-softmmu/config-devices.mak
  GEN   ppcemb-softmmu/config-devices.mak
  GEN   ppc64-softmmu/config-devices.mak
  GEN   sh4-softmmu/config-devices.mak
  GEN   sh4eb-softmmu/config-devices.mak
  GEN   sparc-softmmu/config-devices.mak
  GEN   s390x-softmmu/config-devices.mak
  GEN   sparc64-softmmu/config-devices.mak
  GEN   xtensa-softmmu/config-devices.mak
  GEN   xtensaeb-softmmu/config-devices.mak
  GEN   unicore32-softmmu/config-devices.mak
  GEN   i386-linux-user/config-devices.mak
  GEN   x86_64-linux-user/config-devices.mak
  GEN   alpha-linux-user/config-devices.mak
  GEN   arm-linux-user/config-devices.mak
  GEN   cris-linux-user/config-devices.mak
  GEN   armeb-linux-user/config-devices.mak
  GEN   microblaze-linux-user/config-devices.mak
  GEN   m68k-linux-user/config-devices.mak
  GEN   microblazeel-linux-user/config-devices.mak
  GEN   mips-linux-user/config-devices.mak
  GEN   mipsel-linux-user/config-devices.mak
  GEN   or32-linux-user/config-devices.mak
  GEN   ppc-linux-user/config-devices.mak
  GEN   ppc64abi32-linux-user/config-devices.mak
  GEN   sh4-linux-user/config-devices.mak
  GEN   ppc64-linux-user/config-devices.mak
  GEN   sh4eb-linux-user/config-devices.mak
  GEN   sparc-linux-user/config-devices.mak
  GEN   sparc64-linux-user/config-devices.mak
  GEN   sparc32plus-linux-user/config-devices.mak
  GEN   s390x-linux-user/config-devices.mak
  GEN   unicore32-linux-user/config-devices.mak
  GEN   config-host.h
  GEN   qemu-options.def
  GEN   qmp-commands.h
  GEN   qapi-types.h
  GEN   qapi-visit.h
  GEN   tests/test-qapi-types.h
  GEN   tests/test-qapi-visit.h
  GEN   tests/test-qmp-commands.h
  GEN   trace/generated-tracers.h
  GEN   config-all-devices.mak
  GEN   qemu-options.texi
  GEN   qemu-monitor.texi
  GEN   qemu-img-cmds.texi
  GEN   qemu-tech.html
  GEN   qemu-nbd.8
  GEN   QMP/qmp-commands.txt
  GEN   qapi-types.c
  GEN   qga/qapi-generated/qga-qapi-types.h
  GEN   qga/qapi-generated/qga-qmp-commands.h
  GEN   qga/qapi-generated/qga-qapi-visit.h
  GEN   qapi-visit.c
  GEN   qga/qapi-generated/qga-qapi-types.c
  GEN   qga/qapi-generated/qga-qapi-visit.c
  GEN   qga/qapi-generated/qga-qmp-marshal.c
  CC    qapi/qapi-visit-core.o
  CC    qapi/qapi-dealloc-visitor.o
  CC    qapi/qmp-input-visitor.o
  CC    qapi/qmp-output-visitor.o
  CC    qapi/qmp-registry.o
  CC    qapi/qmp-dispatch.o
  CC    qapi/string-input-visitor.o
  CC    qapi/string-output-visitor.o
  CC    qapi/opts-visitor.o
  CC    qobject/qint.o
  CC    qobject/qstring.o
  CC    qobject/qdict.o
  CC    qobject/qlist.o
  CC    qobject/qfloat.o
  CC    qobject/qbool.o
  CC    qobject/qjson.o
  CC    qobject/json-lexer.o
  CC    qobject/json-streamer.o
  CC    qobject/json-parser.o
  CC    qobject/qerror.o
  CC    trace/default.o
  CC    trace/control.o
  GEN   trace/generated-tracers.c
  CC    util/osdep.o
  CC    util/cutils.o
  CC    util/qemu-timer-common.o
  CC    util/oslib-posix.o
  CC    util/qemu-thread-posix.o
  CC    util/event_notifier-posix.o
  CC    util/envlist.o
  CC    util/path.o
  CC    util/host-utils.o
  CC    util/cache-utils.o
  CC    util/module.o
  CC    util/bitmap.o
  CC    util/bitops.o
  CC    util/hbitmap.o
  CC    util/acl.o
  CC    util/error.o
  CC    util/qemu-error.o
  CC    util/compatfd.o
  CC    util/iov.o
  CC    util/aes.o
  CC    util/qemu-config.o
  CC    util/qemu-sockets.o
  CC    util/uri.o
  CC    util/notify.o
  CC    util/qemu-option.o
  CC    util/qemu-progress.o
  CC    stubs/arch-query-cpu-def.o
  CC    stubs/clock-warp.o
  CC    stubs/cpu-get-clock.o
  CC    stubs/cpu-get-icount.o
  CC    stubs/fdset-add-fd.o
  CC    stubs/fdset-find-fd.o
  CC    stubs/fdset-get-fd.o
  CC    stubs/fdset-remove-fd.o
  CC    stubs/get-fd.o
  CC    stubs/get-vm-name.o
  CC    stubs/iothread-lock.o
  CC    stubs/migr-blocker.o
  CC    stubs/mon-is-qmp.o
  CC    stubs/mon-printf.o
  CC    stubs/mon-print-filename.o
  CC    stubs/mon-protocol-event.o
  CC    stubs/mon-set-error.o
  CC    stubs/reset.o
  CC    stubs/set-fd-handler.o
  CC    stubs/slirp.o
  CC    stubs/sysbus.o
  CC    stubs/vm-stop.o
  CC    stubs/vmstate.o
  CC    qemu-nbd.o
  CC    async.o
  CC    thread-pool.o
  CC    nbd.o
  CC    block.o
  CC    blockjob.o
  CC    main-loop.o
  CC    iohandler.o
  CC    qemu-timer.o
  CC    aio-posix.o
  CC    qemu-coroutine.o
  CC    qemu-coroutine-lock.o
  CC    qemu-coroutine-io.o
  CC    qemu-coroutine-sleep.o
  CC    coroutine-ucontext.o
  CC    block/raw.o
  CC    block/cow.o
  CC    block/qcow.o
  CC    block/vdi.o
  CC    block/vmdk.o
  CC    block/cloop.o
  CC    block/dmg.o
  CC    block/bochs.o
  CC    block/vpc.o
  CC    block/vvfat.o
  CC    block/qcow2.o
  CC    block/qcow2-refcount.o
  CC    block/qcow2-cluster.o
  CC    block/qcow2-snapshot.o
  CC    block/qcow2-cache.o
  CC    block/qed.o
  CC    block/qed-gencb.o
  CC    block/qed-l2-cache.o
  CC    block/qed-table.o
  CC    block/qed-cluster.o
  CC    block/qed-check.o
  CC    block/parallels.o
  CC    block/blkdebug.o
  CC    block/blkverify.o
  CC    block/raw-posix.o
  CC    block/linux-aio.o
  CC    block/nbd.o
  CC    block/sheepdog.o
  GEN   qemu-img-cmds.h
  CC    qemu-io.o
  CC    cmd.o
  CC    qemu-bridge-helper.o
  CC    blockdev.o
  CC    blockdev-nbd.o
  CC    readline.o
  CC    os-posix.o
  CC    migration.o
  CC    migration-tcp.o
  CC    qemu-char.o
  CC    block-migration.o
  CC    page_cache.o
  CC    migration-exec.o
  CC    migration-unix.o
  CC    migration-fd.o
  CC    bt-host.o
  CC    bt-vhci.o
  CC    dma-helpers.o
  CC    qtest.o
  CC    vl.o
  GEN   qmp-marshal.c
  CC    qmp.o
  CC    hmp.o
  CC    qemu-log.o
  CC    tcg-runtime.o
  CC    audio/audio.o
  CC    audio/noaudio.o
  CC    audio/wavaudio.o
  CC    audio/mixeng.o
  CC    audio/ossaudio.o
  CC    audio/wavcapture.o
  CC    backends/rng.o
  CC    backends/rng-egd.o
  CC    backends/rng-random.o
  CC    block/stream.o
  CC    block/commit.o
  CC    block/mirror.o
vl.c: In function 'main':
vl.c:3618:17: error: 'default_sclp' undeclared (first use in this function)
vl.c:3618:17: note: each undeclared identifier is reported only once for each 
function it appears in
make: *** [vl.o] Error 1
make: *** Waiting for unfinished jobs....


Regards,

Anthony Liguori