[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V6 20/33] qcow2: Add a deduplication boolean to up
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC V6 20/33] qcow2: Add a deduplication boolean to update_refcount. |
Date: |
Thu, 7 Feb 2013 11:24:44 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 06, 2013 at 01:31:53PM +0100, Benoît Canet wrote:
> @@ -427,7 +427,7 @@ fail_block:
>
> /* XXX: cache several refcount block clusters ? */
> int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
> - int64_t offset, int64_t length, int addend)
> + int64_t offset, int64_t length, int addend, bool deduplication)
This is a layering violation and is easy to avoid. More details in
reply to the next patch.
Stefan
- [Qemu-devel] [RFC V6 12/33] qcow2: Makes qcow2_alloc_cluster_link_l2 mark to deduplicate clusters., (continued)
- [Qemu-devel] [RFC V6 12/33] qcow2: Makes qcow2_alloc_cluster_link_l2 mark to deduplicate clusters., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 17/33] qcow2-cache: Allow to choose table size at creation., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 15/33] qcow2: Load and save deduplication table header extension., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 18/33] qcow2: Extract qcow2_add_feature and qcow2_remove_feature., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 16/33] qcow2: Extract qcow2_do_table_init., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 20/33] qcow2: Add a deduplication boolean to update_refcount., Benoît Canet, 2013/02/06
- Re: [Qemu-devel] [RFC V6 20/33] qcow2: Add a deduplication boolean to update_refcount.,
Stefan Hajnoczi <=
- [Qemu-devel] [RFC V6 21/33] qcow2: Drop hash for a given cluster when dedup makes refcount > 2^16/2., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 22/33] qcow2: Remove hash when cluster is deleted., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 19/33] block: Add qcow2_dedup format and image creation code., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 25/33] qcow2: Serialize write requests when deduplication is activated., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 30/33] qcow2: Integrate SKEIN hash algorithm in deduplication., Benoît Canet, 2013/02/06