Re: [Qemu-devel] [RFC V2 7/7] qmp: Add block-dedup-control.

[Eric Blake]

On 02/06/2013 05:32 AM, Benoît Canet wrote:
> ---
>  blockdev.c       |   20 ++++++++++++++++++++
>  qapi-schema.json |   19 +++++++++++++++++++
>  qmp-commands.hx  |   25 +++++++++++++++++++++++++
>  3 files changed, 64 insertions(+)
> 

> +++ b/qapi-schema.json
> @@ -812,6 +812,25 @@
>  ##
>  { 'enum': 'DedupStatus', 'data': [ 'stopped', 'starting', 'started',
>                                     'stopping' ] }
> +##
> +# @block-dedup-control:
> +#
> +# This command pause the deduplication on a device that supports it.

s/pause/controls/, or copy your wording from the .hx file.

> +#
> +# @device:   the name of the device to control the deduplication for
> +# @enable:   true to start, false to stop
> +#
> +# Returns: nothing on success
> +#          If @device is not a valid block device, DeviceNotFound
> +#          GenericError if @device is not deduplicated

Most API in this file don't bother calling out GenericError; it is
implicit that pretty much any function is allowed to fail with a
GenericError and that the text of the error message would hopefully
explain why.

> +SQMP
> +block-dedup-control
> +------------
> +
> +Start or stop the deduplication on a device that support it.

s/support/supports/

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature