[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V6 29/33] qcow2: Do not overwrite existing entries
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC V6 29/33] qcow2: Do not overwrite existing entries with QCOW_OFLAG_COPIED. |
Date: |
Fri, 8 Feb 2013 12:03:46 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 06, 2013 at 01:32:02PM +0100, Benoît Canet wrote:
> In the case of a race condition between two writes a l2 entry can be written
> without QCOW_OFLAG_COPIED before the first write fill it.
> This patch simply check if the l2 entry has the correct offset without
> QCOW_OFLAG_COPIED and do nothing.
>
> Signed-off-by: Benoit Canet <address@hidden>
> ---
> block/qcow2-cluster.c | 5 +++++
> 1 file changed, 5 insertions(+)
Is this a general qcow2 bug (without deduplication)?
I thought there is L2Meta wait code in qcow2_co_writev() that prevents
overlapping writes from executing at the same time?
- Re: [Qemu-devel] [RFC V6 27/33] qcow2: Adapt checking of QCOW_OFLAG_COPIED for dedup., (continued)
[Qemu-devel] [RFC V6 07/33] qcow2: Add qcow2_dedup and related functions, Benoît Canet, 2013/02/06
[Qemu-devel] [RFC V6 13/33] qcow2: make the deduplication forget a cluster hash when a cluster is to dedupe, Benoît Canet, 2013/02/06
[Qemu-devel] [RFC V6 29/33] qcow2: Do not overwrite existing entries with QCOW_OFLAG_COPIED., Benoît Canet, 2013/02/06
- Re: [Qemu-devel] [RFC V6 29/33] qcow2: Do not overwrite existing entries with QCOW_OFLAG_COPIED.,
Stefan Hajnoczi <=
[Qemu-devel] [RFC V6 26/33] qcow2: Add verification of dedup table., Benoît Canet, 2013/02/06
[Qemu-devel] [RFC V6 23/33] qcow2: Add qcow2_dedup_is_running to probe if dedup is running., Benoît Canet, 2013/02/06
[Qemu-devel] [RFC V6 24/33] qcow2: Integrate deduplication in qcow2_co_writev loop., Benoît Canet, 2013/02/06
[Qemu-devel] [RFC V6 14/33] qcow2: Create qcow2_is_cluster_to_dedup., Benoît Canet, 2013/02/06