[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V6 31/33] qcow: Set large dedup hash block size.
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC V6 31/33] qcow: Set large dedup hash block size. |
Date: |
Fri, 8 Feb 2013 12:07:28 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Feb 06, 2013 at 01:32:04PM +0100, Benoît Canet wrote:
> diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
> index 337fb65..d173c18 100644
> --- a/block/qcow2-refcount.c
> +++ b/block/qcow2-refcount.c
> @@ -1051,7 +1051,7 @@ static int check_dedup_l2(BlockDriverState *bs,
> BdrvCheckResult *res,
> int i, l2_size;
>
> /* Read L2 table from disk */
> - l2_size = s->cluster_size;
> + l2_size = s->hash_block_size;
> l2_table = g_malloc(l2_size);
>
> if (bdrv_pread(bs->file, l2_offset, l2_table, l2_size) != l2_size) {
> @@ -1141,7 +1141,7 @@ static int check_refcounts_l1(BlockDriverState *bs,
> /* Mark L2 table as used */
> l2_offset &= L1E_OFFSET_MASK;
> inc_refcounts(bs, res, refcount_table, refcount_table_size,
> - l2_offset, s->cluster_size);
> + l2_offset, dedup ? s->hash_block_size : s->l2_size << 3);
Why s->l2_size << 3 instead of s->cluster_size for the non-dedup case?
- Re: [Qemu-devel] [RFC V6 22/33] qcow2: Remove hash when cluster is deleted., (continued)
- [Qemu-devel] [RFC V6 19/33] block: Add qcow2_dedup format and image creation code., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 25/33] qcow2: Serialize write requests when deduplication is activated., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 30/33] qcow2: Integrate SKEIN hash algorithm in deduplication., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 32/33] qemu-iotests: Filter dedup=on/off so existing tests don't break., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 31/33] qcow: Set large dedup hash block size., Benoît Canet, 2013/02/06
- Re: [Qemu-devel] [RFC V6 31/33] qcow: Set large dedup hash block size.,
Stefan Hajnoczi <=
- [Qemu-devel] [RFC V6 33/33] qcow2: Add qcow2_dedup_init and qcow2_dedup_close., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 08/33] qcow2: Add qcow2_dedup_store_new_hashes., Benoît Canet, 2013/02/06
- [Qemu-devel] [RFC V6 27/33] qcow2: Adapt checking of QCOW_OFLAG_COPIED for dedup., Benoît Canet, 2013/02/06