qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH for-1.4 stable v2 0/3] block-migration: fix "Unknown


From: Stefan Hajnoczi
Subject: [Qemu-devel] [PATCH for-1.4 stable v2 0/3] block-migration: fix "Unknown flags" error
Date: Sun, 10 Feb 2013 23:12:43 +0100

Block migration is currently broken.  This series fixes it.

Patch 1 - improve "Unknown flags" error message

Patch 2 - the "Unknown flags" error means the source and destination QEMUs are
not in sync.  The destination expects a block migration message but finds an
unexpected message.  This is because the source is incorrectly returning early
when block migration finishes.

Patch 3 - the source is calling iterate() in an infinite loop and never
completing block migration.  This is because block migration never returns 1 to
stop iterating.

v2:
 * Improve iteration stop condition to check:

   1. Bulk phase has completed (entire image copied)
   2. No aio requests pending
   3. All read blocks have been transferred

   Reno Gan reports this was already broken in qemu-kvm-1.2.0, we're touching
   that code so fix it.

Stefan Hajnoczi (3):
  block-migration: improve "Unknown flags" error message
  block-migration: fix blk_mig_save_dirty_block() return value checking
  block-migration: fix block_save_iterate() return value

 block-migration.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

-- 
1.8.1.2




reply via email to

[Prev in Thread] Current Thread [Next in Thread]