Re: [Qemu-devel] [PATCH 00/10] Support mips64/mipsn32-linux-user

[Peter Maydell]

On 11 February 2013 15:45, Richard Henderson <address@hidden> wrote:
> On 2013-02-11 01:59, Peter Maydell wrote:
>> Eight patches out of ten have no commit message beyond the
>> one-liner summary...

> Ok, so?  Most of the patches are microscopic,
> and do exactly what the summary says.

Well, just to start with, I looked at patch 1 and thought
"why is it ok to delete these without it making something
fail to compile?". That's the kind of question I tend to
expect to be addressed in a commit message. Patches without
good commit messages are like code without comments: they
work, but they're more effort to review because the
author never explains the 'why' of anything. One or two
patches might have one-liner commit messages, sure, but 80%
of a ten-patch series?

Sure, to some extent this is personal style preferences, but
that's generally fair game in patch review. As always with
review comments, you are free to ignore them :-)

-- PMM