[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH RDMA support v2: 3/6] install new monitor co
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH RDMA support v2: 3/6] install new monitor commands and setup RDMA capabilities |
|
Date: |
Tue, 12 Feb 2013 10:05:33 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 02/11/2013 08:06 PM, Michael R. Hines wrote:
[no need to top-post on a technical list]
> None of the other migration QMP commands use dashes.
Then how do you explain 'query-migrate', 'migrate-set-capabilities',
'query-migrate-capabilities', 'migrate-set-cache-size',
'query-migrate-cache-size'? I argue that 'migrate_cancel' and
'migrate_set_downtime' are the odd ones out, and only because they were
written before our current policy of preferring dash.
> Shouldn't I stay consistent with the other commands?
Yes, which is why I'm arguing for using dash.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
[Qemu-devel] [RFC PATCH RDMA support v2: 3/6] install new monitor commands and setup RDMA capabilities, Michael R. Hines, 2013/02/11
[Qemu-devel] [RFC PATCH RDMA support v2: 2/6] create migration-rdma.c for core RDMA migration code, Michael R. Hines, 2013/02/11
[Qemu-devel] [RFC PATCH RDMA support v2: 5/6] connection-setup code between client/server, Michael R. Hines, 2013/02/11