Re: [Qemu-devel] [PATCH] iscsi: add iscsi_truncate support

[Paolo Bonzini]

Il 15/02/2013 12:18, Peter Lieven ha scritto:
>>>
>>> +    task = iscsi_readcapacity16_task(iscsilun->iscsi, iscsilun->lun,
>>> +                                 iscsi_readcapacity16_cb, &itask);
>>
>> You can use iscsi_readcapacity16_sync.  In fact, you probably should
>> extract code from iscsi_open and reuse it here.
> 
> Thats not possible afaik. Mixing sync and async commands in libiscsi is
> a very bad thing. It will leed to nested event loops.

Ah, I thought qmp_block_resize did a bdrv_drain_all before calling
bdrv_truncate.

Maybe it should.  Kevin, what do you think?

Paolo