[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv3] iscsi: add iscsi_truncate support
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCHv3] iscsi: add iscsi_truncate support |
Date: |
Mon, 18 Feb 2013 14:06:09 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
Il 18/02/2013 14:04, Peter Lieven ha scritto:
>>>
>>
>> I didn't write to *remove* the switch statement, I wrote to *move* it
>> into a new function and use it from iscsi_truncate.
>
> Sorry, not enough sleep. However, truncate makes only sense for lun type
> disk, doesn't it?
I think so, mostly because anyway you can use "change" to reset the
capacity on TYPE_ROM, they are removable. But still the code looks
better that way.
Paolo
- Re: [Qemu-devel] [PATCH] iscsi: add iscsi_truncate support, (continued)
- Re: [Qemu-devel] [PATCH] iscsi: add iscsi_truncate support, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCHv2] iscsi: add iscsi_truncate support, Peter Lieven, 2013/02/15
- Re: [Qemu-devel] [PATCHv2] iscsi: add iscsi_truncate support, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH] block: complete all IOs before .bdrv_truncate, Peter Lieven, 2013/02/18
- Re: [Qemu-devel] [PATCH] block: complete all IOs before .bdrv_truncate, Paolo Bonzini, 2013/02/18
- Re: [Qemu-devel] [PATCH] block: complete all IOs before .bdrv_truncate, Kevin Wolf, 2013/02/20
- Re: [Qemu-devel] [PATCH] block: complete all IOs before .bdrv_truncate, Eric Blake, 2013/02/18
- [Qemu-devel] [PATCHv3] iscsi: add iscsi_truncate support, Peter Lieven, 2013/02/18
- Re: [Qemu-devel] [PATCHv3] iscsi: add iscsi_truncate support, Paolo Bonzini, 2013/02/18
- Re: [Qemu-devel] [PATCHv3] iscsi: add iscsi_truncate support, Peter Lieven, 2013/02/18
- Re: [Qemu-devel] [PATCHv3] iscsi: add iscsi_truncate support,
Paolo Bonzini <=
- [Qemu-devel] [PATCHv4] iscsi: add iscsi_truncate support, Peter Lieven, 2013/02/18
- Re: [Qemu-devel] [PATCHv4] iscsi: add iscsi_truncate support, Paolo Bonzini, 2013/02/25