[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/9] ui: add basic GTK gui (v4)
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 3/9] ui: add basic GTK gui (v4) |
Date: |
Tue, 19 Feb 2013 10:07:04 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130108 Thunderbird/10.0.12 |
Hi,
On 02/19/13 00:56, Anthony Liguori wrote:
> +static void gd_resize(DisplayState *ds)
> +{
> + GtkDisplayState *s = ds->opaque;
> + cairo_format_t kind;
> + int stride;
> +
> + DPRINTF("resize(width=%d, height=%d)\n",
> + ds_get_width(ds), ds_get_height(ds));
> +
> + if (s->surface) {
> + cairo_surface_destroy(s->surface);
> + }
Isn't cairo backed by pixman under the hood?
I suspect you should be able to simply pass the pixman image
(ds->surface->image) directly to cairo for rendering, thereby making
this function alot simpler.
cheers,
Gerd
- [Qemu-devel] [PATCH 0/9] Add GTK UI to enable basic accessibility (v4), Anthony Liguori, 2013/02/18
- [Qemu-devel] [PATCH 1/9] build: disable Wstrict-prototypes, Anthony Liguori, 2013/02/18
- [Qemu-devel] [PATCH 2/9] console: allow VCs to be overridden by UI, Anthony Liguori, 2013/02/18
- [Qemu-devel] [PATCH 4/9] gtk: add virtual console support (v2), Anthony Liguori, 2013/02/18
- [Qemu-devel] [PATCH 5/9] gtk: add support for input grabbing (v2), Anthony Liguori, 2013/02/18
- [Qemu-devel] [PATCH 3/9] ui: add basic GTK gui (v4), Anthony Liguori, 2013/02/18
- [Qemu-devel] [PATCH 6/9] gtk: add support for screen scaling and full screen (v3), Anthony Liguori, 2013/02/18
- [Qemu-devel] [PATCH 8/9] gtk: make default UI (v3), Anthony Liguori, 2013/02/18