[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.4] pc: tag apic as overlap region
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH for-1.4] pc: tag apic as overlap region |
Date: |
Tue, 19 Feb 2013 17:05:03 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2013-02-19 16:54, Peter Maydell wrote:
> On 19 February 2013 15:51, Jan Kiszka <address@hidden> wrote:
>> On 2013-02-19 16:20, Michael S. Tsirkin wrote:
>>> qdev_init_nofail(dev);
>>> d = SYS_BUS_DEVICE(dev);
>>> - sysbus_mmio_map(d, 0, 0xfec00000);
>>> + /* APIC overlaps the PCI window. */
>>> + sysbus_mmio_map_overlap(d, 0, 0xfec00000, 1000);
>>
>> That's the IOAPIC, not the APIC. If you mean the IOAPIC, APIC and HPET
>> would require higher prio, too. But I suppose this is really about the
>> APIC and its special priority due to CPU-local access dispatching, right?
>
> Is this a proposed minimally invasive patch for 1.4 with a
> different approach (possibly involving reworking things with
> a better managed set of container regions) for master, or
> is this the planned fix for master too?
I'm not yet sure we need any overhaul at all. If hardware prioritizes
certain windows like APIC, IOAPIC, HPET over PCI device mappings, then
we can already express this today - we just need to do it.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
Re: [Qemu-devel] [PATCH for-1.4] pc: tag apic as overlap region, Alexey Korolev, 2013/02/21