[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] pc_piix: Add compat handling for qemu-kvm V
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] pc_piix: Add compat handling for qemu-kvm VGA mem size |
Date: |
Tue, 19 Feb 2013 23:52:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
Il 19/02/2013 23:40, Cole Robinson ha scritto:
> +#ifdef CONFIG_MIGRATE_FROM_QEMU_KVM
> +/* qemu-kvm defaulted to 16MB video memory since 0.15 at least. */
> +# define OLD_VGA_MEM stringify(16)
> +#else
> +# define OLD_VGA_MEM stringify(8)
> +#endif
> +
> #define PC_COMPAT_1_2 \
> PC_COMPAT_1_3,\
> {\
> @@ -354,6 +361,10 @@ static QEMUMachine pc_machine_v1_3 = {
> .property = "revision",\
> .value = stringify(3),\
> },{\
> + .driver = "cirrus-vga",\
> + .property = "vgamem_mb",\
> + .value = OLD_VGA_MEM,\
> + },{\
> .driver = "VGA",\
> .property = "mmio",\
> .value = "off",\
Because this is now 1.5, you also need to define pc_machine_v1_4 and add
the compat property there.
Also, please add the "Cc: address@hidden" in the body of the
message. It's an easy way for maintainers to pick up patches only after
they've been committed.
Paolo
Re: [Qemu-devel] [PATCH 1/4] configure: Add --enable-migration-from-qemu-kvm, Anthony Liguori, 2013/02/20