qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] i440fx: implement reset


From: David Woodhouse
Subject: Re: [Qemu-devel] [PATCH] i440fx: implement reset
Date: Wed, 20 Feb 2013 18:04:58 +0000

On Wed, 2013-02-20 at 18:42 +0100, Andreas Färber wrote:
> 
>     PCII440FXState *d = I440FX_PCI_WHATEVER_CAST_MACRO_NAME(dev);

Yeah, that's the easy bit. The bit that I'm vaguely confused by would be
something like

#define I440FX_PCI_WHATEVER_CAST_MACRO_NAME(obj) \
    OBJECT_CHECK(PCII440FXState, (obj), "i440FX") 

Where that "i440FX" should probably be turned into a macro of its own?

And then all the *existing* uses of DO_UPCAST should be fixed to use it
too? Such as in i440fx_write_config() ?

-- 
dwmw2

Attachment: smime.p7s
Description: S/MIME cryptographic signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]