[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver
From: |
Dietmar Maurer |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver |
Date: |
Thu, 21 Feb 2013 11:40:52 +0000 |
> > > I think you do. You're wasting time reading unallocated clusters
> > > and checking that they are zero. bdrv_is_allocated_above gives you
> > > the same information much more efficiently.
> >
> > I thought that just returns information if the data is allocated, or
> > if data is on backing file?
> >
> > Or is data guaranteed to be zero if bdrv_is_allocated_above() return 0?
>
> Oh, I need to pass NULL for base to get that information?
I just posted v5 of the patch. But I get a slow down of 15% if I use
bdrv_is_allocated_above.
(tested with empty qcow2 files.)
Please can you take a look at the code - maybe I am doing something wrong?
- Re: [Qemu-devel] [PATCH v3 3/6] add backup related monitor commands, (continued)
- [Qemu-devel] [PATCH v3 6/6] add vm state to backups, Dietmar Maurer, 2013/02/19
- [Qemu-devel] [PATCH v3 4/6] introduce new vma archive format, Dietmar Maurer, 2013/02/19
- [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver, Dietmar Maurer, 2013/02/19
- Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver, Eric Blake, 2013/02/19
- Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver, Paolo Bonzini, 2013/02/20
- Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver, Dietmar Maurer, 2013/02/21
- Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver, Paolo Bonzini, 2013/02/21
- Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver, Dietmar Maurer, 2013/02/21
- Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver, Dietmar Maurer, 2013/02/21
- Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver,
Dietmar Maurer <=
- Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver, Paolo Bonzini, 2013/02/21
- Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver, Dietmar Maurer, 2013/02/21
- Re: [Qemu-devel] [PATCH v3 2/6] add basic backup support to block driver, Paolo Bonzini, 2013/02/21
Re: [Qemu-devel] [PATCH v3 1/6] RFC: Efficient VM backup for qemu, Eric Blake, 2013/02/19
Re: [Qemu-devel] [PATCH v3 1/6] RFC: Efficient VM backup for qemu, Dietmar Maurer, 2013/02/20