[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 35/41] migration: use QEMUFile for writing outgo
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 35/41] migration: use QEMUFile for writing outgoing migration data |
Date: |
Fri, 22 Feb 2013 12:30:51 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Paolo Bonzini <address@hidden> wrote:
> Second, drop the file descriptor indirection, and write directly to the
> QEMUFile.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> + qemu_put_buffer(s->migration_file, buf, size);
> + if (qemu_file_get_error(s->migration_file)) {
> + return qemu_file_get_error(s->migration_file);
Rest of patch is really, really nice.
But here, please, use a local variable.
qemu_put_buffer(s->migration_file, buf, size);
ret = qemu_file_get_error(s->migration_file);
if (ret) {
return ret;
}
- [Qemu-devel] [PATCH 14/41] migration: cleanup migration (including thread) in the iothread, (continued)
- [Qemu-devel] [PATCH 14/41] migration: cleanup migration (including thread) in the iothread, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 11/41] migration: simplify error handling, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 35/41] migration: use QEMUFile for writing outgoing migration data, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 34/41] migration: use QEMUFile for migration channel lifetime, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 29/41] migration: merge qemu_popen_cmd with qemu_popen, Paolo Bonzini, 2013/02/15
- [Qemu-devel] [PATCH 24/41] qemu-file: make qemu_fflush and qemu_file_set_error private again, Paolo Bonzini, 2013/02/15