Re: [Qemu-devel] [PATCH 1/2] ui/gtk: Support versions of gtk+-2.0 before 2.90.7

[Stefan Weil]

Am 22.02.2013 20:28, schrieb Anthony Liguori:

Stefan Weil <address@hidden> writes:

This is needed for current Debian stable (Squeeze).

Extract from NEWS in gtk+-2.0:

  Overview of Changes from GTK+ 2.90.6 to 2.90.7
  ==============================================

  * All GDK keysym names have been changed from GDK_keysym to GDK_KEY_keysym;
    the previous names are still available in gdkkeysyms-compat.h.

For versions before 2.90.7, the new names are now mapped to the old ones.

Signed-off-by: Stefan Weil <address@hidden>
---
 ui/gtk.c |   11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/ui/gtk.c b/ui/gtk.c
index f82ced0..10bac94 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -64,6 +64,17 @@
 
 #define MAX_VCS 10
 
+#if !GTK_CHECK_VERSION(2, 90, 7)

I'm not sure what you're doing, but you're using GTK-3, not GTK-2.

GDK_f is the GTK-3 name.  It's always been GDK_KEY_f in GTK-2.  Much
like QEMU, 2.90 means 3.0-rc0 for GTK.

Regards,

Anthony Liguori

Please see http://git.gnome.org/browse/gtk+/tree/NEWS
(look for GDK_KEY_keysym).

This and the VTE patch which you have already reviewed
are necessary for Debian stable, so I'd appreciate if
both patches could be applied soon.

Thanks,

Stefan Weil