Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

[Paolo Bonzini]

> Another thing is, that  qdev_free looks now different, some days ago
> it also did an unref. As far as I can see the object_unparent in
> virtio-ccw was always the wrong thing to do.

object_unparent is "almost" idempotent, i.e. idempotent as long as it does
not cause the last reference to go away.  So, doing an object_unparent
before qdev_free was not wrong when qdev_free did an object_unref.

I think qdev_free is better, unless we want to change all of them
at the same time.

Paolo

> So for a potential backport
> this version of the patch might be better.
> Paolo, do you have any guidance?
> 
> Christian
> 
>