Re: [Qemu-devel] [PATCH 7/9] chardev: add stdio support to qapi

[Eric Blake]

On 02/25/2013 02:03 AM, Gerd Hoffmann wrote:
> This patch adds 'stdio' support to qapi and also switches over the
> stdio chardev initialization to the new qapi code path.
> 
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  qapi-schema.json |   14 +++++++++++++-
>  qemu-char.c      |   26 ++++++++++++++++++++------
>  2 files changed, 33 insertions(+), 7 deletions(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index f873451..b0ca67d 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3146,6 +3146,17 @@
>  { 'type': 'ChardevMux', 'data': { 'chardev' : 'str' } }
>  
>  ##
> +# @ChardevStdio:
> +#
> +# Configuration info for stdio chardevs.
> +#
> +# @signal: Allow signals (such as SIGINT triggered by ^C) be delivered to 
> qemu.

It would help to mark this with #optional, and document the default
state if the parameter is omitted.

> +#
> +# Since: 1.5
> +##
> +{ 'type': 'ChardevStdio', 'data': { '*signal' : 'bool' } }
> +
> +##

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature