[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 2/5] iovec checksum calculation fuction
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v11 2/5] iovec checksum calculation fuction |
Date: |
Tue, 26 Feb 2013 10:38:34 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Feb 25, 2013 at 09:37:52PM +0100, Andreas Färber wrote:
> Am 25.02.2013 21:11, schrieb Dmitry Fleytman:
[...]
> > diff --git a/include/net/checksum.h b/include/net/checksum.h
> > index 3e7b93d..b1cf18a 100644
> > --- a/include/net/checksum.h
> > +++ b/include/net/checksum.h
> > @@ -19,6 +19,7 @@
> > #define QEMU_NET_CHECKSUM_H
> >
> > #include <stdint.h>
> > +#include "qemu-common.h"
>
> Eduardo has worked hard to resolve circular qemu-common.h dependencies!
> Are you sure you are not reintroducing one here?
Even if there's no circular dependency yet, this makes it very easy to
introduce circular dependencies silently if one day a header included by
qemu-common.h ends up including checksum.h. That's why qemu-common.h
shouldn't be included by any header file.
> What do you actually
> need out of it? You already have stdint.h for uint32_t, and struct iovec
> is used as pointer so you shouldn't need its internals from
> qemu-common.h here and can include it from checksum.c instead.
>
[...]
--
Eduardo
- [Qemu-devel] [PATCH V11 0/5] VMXNET3 paravirtual NIC device implementation, Dmitry Fleytman, 2013/02/25
- [Qemu-devel] [PATCH v11 2/5] iovec checksum calculation fuction, Dmitry Fleytman, 2013/02/25
- [Qemu-devel] [PATCH v11 1/5] Checksum-related utility functions, Dmitry Fleytman, 2013/02/25
- [Qemu-devel] [PATCH v11 3/5] Common definitions for VMWARE devices, Dmitry Fleytman, 2013/02/25
- [Qemu-devel] [PATCH v11 4/5] Packet abstraction for VMWARE network devices, Dmitry Fleytman, 2013/02/25
- [Qemu-devel] [PATCH v11 5/5] VMXNET3 device implementation, Dmitry Fleytman, 2013/02/25