qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V7 00/14] add qmp/hmp interfaces for internal sn


From: Wenchao Xia
Subject: Re: [Qemu-devel] [PATCH V7 00/14] add qmp/hmp interfaces for internal snapshot info
Date: Fri, 01 Mar 2013 09:47:29 +0800
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130215 Thunderbird/17.0.3

于 2013-2-28 23:57, Stefan Hajnoczi 写道:
On Tue, Feb 26, 2013 at 06:40:14PM +0800, Wenchao Xia wrote:
   This serial of patches does two things: merge some info code
in qemu-img, and add following interfaces:
1) qmp: query-images
2) qmp: query-snapshots
3) hmp: show internal snapshot info on a single block device
   These patches follows the rule that use qmp to retieve information,
hmp layer just do a translation from qmp object it got, so almost
every hmp interface may have a correlated qmp interface.
   To make code graceful, snapshot retrieving code in qemu and qemu-img
are merged into block.c, and some function name was adjusted to make it
tips better. Now it works as:

    qemu          qemu-img

dump_monitor    dump_stdout
      |--------------|
             |
            qmp
             |
           block

This summary does not explain how the new commands relate to query-block
or why they are necessary.

It is also useful to include QMP examples or the QMP docs in the cover
letter so reviewers know what you are trying to achieve.

  OK, a better explaination would be added in the cover-letter.

--
Best Regards

Wenchao Xia




reply via email to

[Prev in Thread] Current Thread [Next in Thread]