Re: [Qemu-devel] [PATCH 00/10] Support mips64/mipsn32-linux-user

[Aurelien Jarno]

Hi,

On Sun, Feb 10, 2013 at 10:30:40AM -0800, Richard Henderson wrote:
> Peter's recent userland syscall testing has encouraged me to clean
> up and re-submit some ages-old patches to enable userland testing
> of the other mips abis.
> 
> Please review.
> 
> 
> r~
> 
> 
> Richard Henderson (10):
>   mips-linux-user: Delete n32 and n64 signal stubs
>   mips-linux-user: Share o32 code for n32 and n64 signals
>   mips-linux-user: Enable mips64 and mipsn32 linux-user targets
>   mips-linux-user: Save and restore fpu and dsp from sigcontext
>   mips-linux-user: Fix n32 and n64 syscalls
>   mips64-linux-user: Enable 64-bit address mode and fpu
>   mips64-linux-user: Use MIPS64R2-generic as default cpu.
>   target-mips: Fix check_cp1_64bitmode
>   mipsn32-linux-user: Restrict address space to 31-bits.
>   mipsn32-linux-user: Configure the architecture properly
> 

I have applied patches 1, 2, 3, 4, 5, 6 and 10. I have taken the
freedom the fix the typo in patch 4 and also the tabs in patch 10 found
by Peter.

For patch 4, the remarks from Peter are valid, but they concerns already
existing code. It might be nice to follow-up with the corresponding
fixes.

For patches 7 to 9, please see my comments to the individual patch and
follow up if needed with a new patch series. I'll try to work on a "any"
cpu in the next days.

Thanks for the patches and to Peter for the review.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
address@hidden                 http://www.aurel32.net