Re: [Qemu-devel] [PATCH v6 12/24] hw/nand.c: bug fix to erase operation

[Peter Maydell]

On 7 March 2013 10:18, Peter Crosthwaite <address@hidden> wrote:
> This fixes a no-boot bug in u-boot for us as well. RE PMMs comments in
> v5, I realise the desire to fix this properly by rewriting that
> if-else mess, but can we get a merge on this one more immediately to
> get QEMU working again? Rewriting this is probably not at the top of
> either mine or Kuo Jungs priority list but at the same time we would
> like a working boot.

The trouble is that the control flow is so complicated that I don't
feel comfortable saying "yes, this change doesn't break operation
of any of the other commands". That's why I didn't give it a
reviewed-by tag. If you can provide a reasonably coherent explanation
of why it doesn't break anything else with reference to a decent
datasheet, you could convince me it's OK.

-- PMM