Re: [Qemu-devel] [Bug 1151986] [NEW] buffer overflow after block-stream via QMP

[Stefan Hajnoczi]

On Thu, Mar 07, 2013 at 11:02:07AM -0000, Helge Rausch wrote:
> When a block-stream is initiated via QMP and the QMP socket is closed on
> client side before the job is finished, QEMU crashes with a buffer
> overflow, somewhere at the end of the streaming process.
> 
> Without QMP I can stream via the HMP without problems. After crashing, I
> cannot boot from the active image anymore.
> 
> I was able to reproduce this with qemu-kvm and qemu-system-x86_64 on two
> different machines.
> 
> Version:
> QEMU emulator version 1.2.0 (qemu-kvm-1.2.0), Copyright (c) 2003-2008 Fabrice 
> Bellard

I cannot reproduce this with qemu-system-x86-1.2.2-6.fc18.x86_64.

> I started QEMU with the following script:
> 
> qemu-kvm \
>  -monitor vc \
>  -m 512 \
>  -hda "$1" \
>  -net nic,vlan=0 \
>  -net user,vlan=0 \
>  -localtime \
>  -smp 2 \
>  -qmp tcp:localhost:4444,server,nowait

I used your command-line and the following QMP commands:

$ QMP/qmp-shell localhost:4444
(QEMU) blockdev-snapshot-sync device=ide0-hd0 snapshot-file=test2.qcow2
(QEMU) block-stream ide0-hd0
(QEMU) query-block-jobs
...output shows the job running...
(QEMU) Ctrl+D

The block job completes successfully and I get no crash.

Please try qemu.git/master to see if the bug is still there for you:

$ git clone git://git.qemu-project.org/qemu.git
$ cd qemu
$ ./configure --target-list=x86_64-softmmu
$ make
$ x86_64-softmmu/qemu-system-x86_64-softmmu -enable-kvm ...

Stefan