qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 2/5] net: hub use lock to protect ports list


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 2/5] net: hub use lock to protect ports list
Date: Tue, 12 Mar 2013 09:56:47 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3

Il 07/03/2013 03:53, Liu Ping Fan ha scritto:
> From: Liu Ping Fan <address@hidden>
> 
> Signed-off-by: Liu Ping Fan <address@hidden>
> ---
>  net/hub.c |   27 ++++++++++++++++++++++++++-
>  1 files changed, 26 insertions(+), 1 deletions(-)

You are introducing three locks.  Please document for each one how can
concurrent access to the lock happen, and also the lock hierarchy.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]