[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device. |
Date: |
Tue, 12 Mar 2013 15:12:52 +0000 |
On 12 March 2013 15:08, KONRAD Frédéric <address@hidden> wrote:
> On 12/03/2013 15:42, Peter Maydell wrote:
>>
>> Yes, I see your problem there, but DEFINE_VIRTIO_BLK_SCSI_PROPERTY
>> and DEFINE_DATA_PLANE_PROPERTIES are just convenience macros, not
>> ones that are expected to be used by other code, right? So you can
>> define them with commas (and name them something so it's obvious
>> they're not intended for wider use as property array elements),
>> and then just make sure your public-facing DEFINE_VIRTIO_BLK_PROPERTIES
>> doesn't end with a comma. (You can do that by putting the macros
>> that expand to maybe-comma-or-not at the front, not the end.)
>>
>> -- PMM
>
> ok, I can put a comment which say not to use them?
And suitable macro names (ie not ones which look like all
the other DEFINE_FOO_PROPERTIES ones). Alternatively since the
macro's only used once as far as I can see, you could just not
bother to abstract it out. The virtio-ccw blk properties still
just have inline #ifdefs for the scsi prop for instance.
-- PMM
- [Qemu-devel] [PATCH v6 0/8] virtio-blk refactoring., fred . konrad, 2013/03/12
- [Qemu-devel] [PATCH v6 1/8] virtio-blk: don't use pointer for configuration., fred . konrad, 2013/03/12
- [Qemu-devel] [PATCH v6 3/8] virtio-blk-pci: switch to new API., fred . konrad, 2013/03/12
- [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device., fred . konrad, 2013/03/12
- Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device., Peter Maydell, 2013/03/12
- Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device., KONRAD Frédéric, 2013/03/12
- Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device., Peter Maydell, 2013/03/12
- Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device., KONRAD Frédéric, 2013/03/12
- Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device., KONRAD Frédéric, 2013/03/12
- Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device., Cornelia Huck, 2013/03/12
- Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device., KONRAD Frédéric, 2013/03/13
- Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device., KONRAD Frédéric, 2013/03/13
- Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device., Cornelia Huck, 2013/03/14
- Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device., KONRAD Frédéric, 2013/03/14
- Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device., Cornelia Huck, 2013/03/14
- Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device., KONRAD Frédéric, 2013/03/14
[Qemu-devel] [PATCH v6 4/8] virtio-blk-s390: switch to the new API., fred . konrad, 2013/03/12