Re: [Qemu-devel] [PATCH V9 04/14] block: move collect_snapshots() and collect_image_info() to block/qapi.c

[Eric Blake]

On 03/12/2013 01:41 PM, Eric Blake wrote:
> On 03/11/2013 05:23 AM, Wenchao Xia wrote:
>>   This patch adds block/qapi.c and moves the functions there. To avoid
>> conflict and tip better, macro in header file is BLOCK_QAPI_H instead
>> of QAPI_H. The moving is for making review easier, those functions
>> will be modified and renamed later.
>>

> 
> This is another case of moving code from a BSD file into an LGPLv2+
> file; depending on what the resolution is for 1/14, you should do the
> same thing here.
> 
> Everything else looks okay, but I'm reluctant to add reviewed-by without
> the license issue sorted.

Same argument as for 1/14 - you exercised your right to copy code from a
permissive license into a stronger license, which is an acceptable use
of open source code.  Hence:

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature