[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] hw/sd.c: fix migration of dynamically alloc
From: |
Michael Walle |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] hw/sd.c: fix migration of dynamically allocated buffer "buf" |
Date: |
Mon, 18 Mar 2013 19:33:47 +0100 |
User-agent: |
KMail/1.13.5 (Linux/2.6.32-5-686-bigmem; KDE/4.4.5; i686; ; ) |
Am Sonntag 10 März 2013, 14:47:57 schrieb Igor Mitsyanko:
> VMSTATE_BUFFER_UNSAFE should be used for buffers inlined in device state,
> not for buffers allocated dynamically. Change to
> VMSTATE_BUFFER_POINTER_UNSAFE macro, which will do migration right.
>
> Signed-off-by: Igor Mitsyanko <address@hidden>
> ---
> hw/sd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/sd.c b/hw/sd.c
> index 428bd78..88eaaf8 100644
> --- a/hw/sd.c
> +++ b/hw/sd.c
> @@ -478,7 +478,7 @@ static const VMStateDescription sd_vmstate = {
> VMSTATE_UINT64(data_start, SDState),
> VMSTATE_UINT32(data_offset, SDState),
> VMSTATE_UINT8_ARRAY(data, SDState, 512),
> - VMSTATE_BUFFER_UNSAFE(buf, SDState, 1, 512),
> + VMSTATE_BUFFER_POINTER_UNSAFE(buf, SDState, 1, 512),
> VMSTATE_BOOL(enable, SDState),
> VMSTATE_END_OF_LIST()
> }
Tested-by: Michael Walle <address@hidden>
--
michael
- [Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage, Igor Mitsyanko, 2013/03/10
- [Qemu-devel] [PATCH 1/3] vmstate.h: introduce VMSTATE_BUFFER_POINTER_UNSAFE macro, Igor Mitsyanko, 2013/03/10
- [Qemu-devel] [PATCH 2/3] hw/sd.c: fix migration of dynamically allocated buffer "buf", Igor Mitsyanko, 2013/03/10
- Re: [Qemu-devel] [PATCH 2/3] hw/sd.c: fix migration of dynamically allocated buffer "buf",
Michael Walle <=
- [Qemu-devel] [PATCH 3/3] hw/onenand.c: fix migration of dynamically allocated buffer "otp", Igor Mitsyanko, 2013/03/10
- Re: [Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage, Peter Maydell, 2013/03/15
- Re: [Qemu-devel] [PATCH 0/3] Fix VMSTATE_BUFFER_UNSAFE macro usage, Peter Maydell, 2013/03/18