[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 7/8] spice-qemu-char: Register interface on post
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 7/8] spice-qemu-char: Register interface on post load |
Date: |
Tue, 19 Mar 2013 08:05:26 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130307 Thunderbird/17.0.3 |
On 03/14/13 17:36, Hans de Goede wrote:
> From: Alon Levy <address@hidden>
>
> The target has not seen the guest_connected event via
> spice_chr_guest_open or spice_chr_write, and so spice server wrongly
> assumes there is no agent active, while the client continues to send
> motion events only by the agent channel, which the server ignores. The
> net effect is that the mouse is static in the guest.
>
> By registering the interface on post load spice server will pass on the
> agent messages fixing the mouse behavior after migration.
> +static VMStateDescription spice_chr_vmstate = {
> + .name = "spice-chr",
> + .version_id = 1,
> + .minimum_version_id = 1,
> + .post_load = spice_chr_post_load,
> + .fields = (VMStateField[]) {
> + VMSTATE_UINT32(guest_open, SpiceCharDriver),
> + VMSTATE_END_OF_LIST()
> + },
> +};
> + vmstate_register(NULL, -1, &spice_chr_vmstate, s);
> +
That is a showstopper. If there are two of these there is no reliable
way to figure which is which.
Do we actually need that in the first place? I assume virtio-serial
will migrate the guest-open state anyway. So if we can use that somehow
we don't have to live migrate the chardev state ...
cheers,
Gerd
- [Qemu-devel] Spice / usb-redir chardev flowcontrol patches v2, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 1/8] virtio-console: Also throttle when less was written then requested, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 4/8] spice-qemu-char: Add watch support, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 2/8] virtio-console: Remove any pending watches on close, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 3/8] spice-qemu-char: Remove #ifdef-ed code for old spice-server compat, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 7/8] spice-qemu-char: Register interface on post load, Hans de Goede, 2013/03/14
- Re: [Qemu-devel] [PATCH 7/8] spice-qemu-char: Register interface on post load,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 6/8] spice-qemu-char: Move spice_chr_close down, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 8/8] usb-redir: Add flow control support, Hans de Goede, 2013/03/14
- [Qemu-devel] [PATCH 5/8] spice-qemu-char: Remove intermediate buffer, Hans de Goede, 2013/03/14
- Re: [Qemu-devel] Spice / usb-redir chardev flowcontrol patches v2, Amit Shah, 2013/03/18