Re: [Qemu-devel] qemu segfault parsing iscsi options

[Peter Lieven]

On 19.03.2013 09:25, Markus Armbruster wrote:
> Peter Lieven <address@hidden> writes:
>
> > On 18.03.2013 13:52, Markus Armbruster wrote:
> > > Peter Lieven <address@hidden> writes:
> > >
> > > > Hi,
> > > >
> > > > with recent qemu from git qemu segfaults with the following commandline:
> > > >
> > > > x86_64-softmmu/qemu-system-x86_64 -iscsi test
> > > >
> > > > qemu-system-x86_64: -iscsi test: There is no option group 'iscsi'
> > > > Speicherzugriffsfehler (Speicherabzug geschrieben)
> > > >
> > > > It seems that there is something missing regarding the iscsi options
> > > > in qemu-option.hx.
> > > >
> > > > This was working with qemu-kvm-1.2.0.
> > >
> > > Works for me with current master 225dc991.
> >
> > for me it doesn't...
> >
> > ~/git/qemu$ git log -1 --oneline
> > 225dc99 s390: Fix cpu refactoring fallout.
> >
> > there is definetly missing some parts in qemu-options.hx for -iscsi
>
> Nope.  It's an initialization order issue.

yes, you are right. so Paolo's patch needs to be fixed. The patch
series fixes at least the iSCSI part.

> Paolo's commit 4d454574 "qemu-option: move standard option definitions
> out of qemu-config.c" moved option group registration from compile time
> (initializer of vm_config_groups[]) to run time (various places).
>
> Registration of group "iscsi" moved to iscsi_block_init(), a block
> driver initialization function.  These are run by
> bdrv_init_with_whitelist(), which gets called only after command line
> parsing.  Oops.
>
> I'm afraid we need to re-review all of that commit for similar
> initialization order errors.

From a quick look at the code, it could be that -spice is broken.
-fsdev and -virtfs work.
I have not find any other invocations of qemu_add_opts outside vl.c

Peter.