qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr
Date: Tue, 19 Mar 2013 11:32:34 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3

On 03/19/2013 10:20 AM, Fabien Chouteau wrote:
> Cleaner solution indeed. I'll do the opposite, store_fpscr calls 
> helper_store_fpscr.

The declarations won't be in the right places for that to work right.

Canonically, cpu_store_fpscr should be declared in cpu.h, have the leading
"cpu_" prefix, and then helper_store_fpscr is declared (via macro) in helper.h
and its definition should call the cpu.h function.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]