[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/11] nbd: Keep hostname and port separate
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 04/11] nbd: Keep hostname and port separate |
Date: |
Tue, 19 Mar 2013 14:56:14 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/18/2013 11:23 AM, Kevin Wolf wrote:
> The NBD block supports an URL syntax, for which a URL parser returns
> separate hostname and port fields. It also supports the traditional qemu
> syntax encoded in a filename. Until now, after parsing the URL to get
> each piece of information, a new string is built to be fed to socket
> functions.
>
> Instead of building a string in the URL case that is immediately parsed
> again, parse the string in both cases and use the QemuOpts interface to
> qemu-sockets.c.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/nbd.c | 49 ++++++++++++++++++++++++++++++++++++++++---------
> include/block/nbd.h | 2 ++
> include/qemu/sockets.h | 1 +
> nbd.c | 12 ++++++++++++
> util/qemu-sockets.c | 6 +++---
> 5 files changed, 58 insertions(+), 12 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/11] block: Driver-specific options for protocols, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 04/11] nbd: Keep hostname and port separate, Kevin Wolf, 2013/03/18
- Re: [Qemu-devel] [PATCH 04/11] nbd: Keep hostname and port separate,
Eric Blake <=
- [Qemu-devel] [PATCH 01/11] block: Add options QDict to bdrv_file_open() prototypes, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 09/11] block: Make find_image_format safe with NULL filename, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 07/11] block: Introduce .bdrv_parse_filename callback, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 06/11] nbd: Accept -drive options for the network connection, Kevin Wolf, 2013/03/18
- [Qemu-devel] [PATCH 08/11] block: Rename variable to avoid shadowing, Kevin Wolf, 2013/03/18