Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

[Paolo Bonzini]

Il 19/03/2013 20:37, Peter Lieven ha scritto:
> 
> Am 19.03.2013 um 18:07 schrieb Paolo Bonzini <address@hidden>:
> 
>> Il 19/03/2013 16:54, Peter Lieven ha scritto:
>>> On 19.03.2013 12:18, Paolo Bonzini wrote:
>>>> Il 19/03/2013 09:51, Markus Armbruster ha scritto:
>>>>> Paolo, please have a look.
>>>> Why isn't it enough to call bdrv_init_with_whitelist earlier?
>>>>
>>>> There is no conditional logic in it, the whitelist is checked at open
>>>> time.
>>>
>>> Has anyone tested if -spice is working?
>>
>> It is.
>>
>> machine_init entries are processed just below the other qemu_add_opts.
> 
> Ok, if you agree I would prepare a new version of this patch set with 3 
> patches:
> 
> 1) move up brd_init_with_whitelist
> 2) throw an error if -iscsi is used without compile libiscsi support
> 3) assert that QemuOptsList != NULL to avoid further segfaults.
> 
> I currently see a segfault on VM start in libiscsi with latest git. Whereas 
> my old
> qemu-kvm 1.2.0 is working with the same command line and libiscsi library.
> As soon as I have sorted this out I will send a new patch set.

I don't think (3) is that important, but yes, that's the plan.

Paolo