[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/7] net: use socket_set_nodelay() for -netdev socke
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 1/7] net: use socket_set_nodelay() for -netdev socket |
Date: |
Mon, 25 Mar 2013 13:26:07 +0100 |
Reduce -netdev socket latency by disabling the Nagle algorithm on
SOCK_STREAM sockets in net/socket.c. Since we are tunelling Ethernet
over TCP we shouldn't artificially delay outgoing packets, let the guest
decide packet scheduling.
I already get sub-millisecond -netdev socket ping times on localhost, so
there was no measurable difference in my testing. This won't hurt
though and may improve remote socket performance.
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Benoit Canet <address@hidden>
Reviewed-by: Daniel P. Berrange <address@hidden>
---
net/socket.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/socket.c b/net/socket.c
index d8b35a2..b0c83e0 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -438,6 +438,9 @@ static NetSocketState
*net_socket_fd_init_stream(NetClientState *peer,
s->fd = fd;
s->listen_fd = -1;
+ /* Disable Nagle algorithm on TCP sockets to reduce latency */
+ socket_set_nodelay(fd);
+
if (is_connected) {
net_socket_connect(s);
} else {
--
1.8.1.4
- Re: [Qemu-devel] [PULL 0/7] Net patches, Stefan Hajnoczi, 2013/03/04
- [Qemu-devel] [PULL 0/7] Net patches, Stefan Hajnoczi, 2013/03/25
- [Qemu-devel] [PATCH 3/7] net: iovec checksum calculator, Stefan Hajnoczi, 2013/03/25
- [Qemu-devel] [PATCH 1/7] net: use socket_set_nodelay() for -netdev socket,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 2/7] Checksum-related utility functions, Stefan Hajnoczi, 2013/03/25
- [Qemu-devel] [PATCH 4/7] Common definitions for VMWARE devices, Stefan Hajnoczi, 2013/03/25
- [Qemu-devel] [PATCH 5/7] Packet abstraction for VMWARE network devices, Stefan Hajnoczi, 2013/03/25
- [Qemu-devel] [PATCH 7/7] net: increase buffer size to accommodate Jumbo frame pkts, Stefan Hajnoczi, 2013/03/25
- [Qemu-devel] [PATCH 6/7] VMXNET3 device implementation, Stefan Hajnoczi, 2013/03/25