[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/19] qcow2: Remove bogus unlock of s->lock
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 02/19] qcow2: Remove bogus unlock of s->lock |
Date: |
Mon, 25 Mar 2013 13:01:12 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/25/2013 11:30 AM, Kevin Wolf wrote:
> The unlock wakes up the next coroutine, but the currently running
> coroutine will lock it again before it yields, so this doesn't make a
> lot of sense.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/qcow2.c | 2 --
> 1 file changed, 2 deletions(-)
Code matches the commit message, but my familiarity with coroutines is
too weak to give a strong review.
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 8ea696a..3f7edf5 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -869,9 +869,7 @@ static coroutine_fn int qcow2_co_writev(BlockDriverState
> *bs,
> QLIST_REMOVE(l2meta, next_in_flight);
> }
>
> - qemu_co_mutex_unlock(&s->lock);
> qemu_co_queue_restart_all(&l2meta->dependent_requests);
> - qemu_co_mutex_lock(&s->lock);
>
> g_free(l2meta);
> l2meta = NULL;
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/19] qcow2: Rework cluster allocation even more, Kevin Wolf, 2013/03/25
- [Qemu-devel] [PATCH 04/19] qcow2: Improve check for overlapping allocations, Kevin Wolf, 2013/03/25
- [Qemu-devel] [PATCH 02/19] qcow2: Remove bogus unlock of s->lock, Kevin Wolf, 2013/03/25
- Re: [Qemu-devel] [PATCH 02/19] qcow2: Remove bogus unlock of s->lock,
Eric Blake <=
- [Qemu-devel] [PATCH 03/19] qcow2: Handle dependencies earlier, Kevin Wolf, 2013/03/25
- [Qemu-devel] [PATCH 01/19] qcow2: Fix "total clusters" number in bdrv_check, Kevin Wolf, 2013/03/25
- [Qemu-devel] [PATCH 06/19] qcow2: Decouple cluster allocation from cluster reuse code, Kevin Wolf, 2013/03/25
- [Qemu-devel] [PATCH 05/19] qcow2: Change handle_dependency to byte granularity, Kevin Wolf, 2013/03/25
- [Qemu-devel] [PATCH 09/19] qcow2: handle_alloc(): Get rid of keep_clusters parameter, Kevin Wolf, 2013/03/25
- [Qemu-devel] [PATCH 08/19] qcow2: handle_alloc(): Get rid of nb_clusters parameter, Kevin Wolf, 2013/03/25
- [Qemu-devel] [PATCH 07/19] qcow2: Factor out handle_alloc(), Kevin Wolf, 2013/03/25
- [Qemu-devel] [PATCH 11/19] qcow2: Clean up handle_alloc(), Kevin Wolf, 2013/03/25
- [Qemu-devel] [PATCH 10/19] qcow2: Finalise interface of handle_alloc(), Kevin Wolf, 2013/03/25