Re: [Qemu-devel] [PATCH 05/12] target-i386: push hot-plugged VCPU state to KVM and unstop it

[Andreas Färber]

Am 27.03.2013 14:27, schrieb Igor Mammedov:
> On Wed, 27 Mar 2013 13:17:45 +0100
> Andreas Färber <address@hidden> wrote:
>>> Then I should move following parts to superclass:
>>>
>>>     if (dev->hotplugged) {
>>>         cpu_synchronize_post_init(env);
>>>         resume_vcpu(CPU(cpu));
>>>     }
>>>
>>> because in case of KVM we should make sure that CPU in sane state before
>>> allowing CPU to become run-able.
>>
>> That's not possible until we change cpu_synchronize_post_init() argument
>> to CPUState, which is somewhere down my TODO list. Currently I have
>> mostly flushed my refactorings out, so if you wanted to dive into that,
>> that would be appreciated. :)
> 
> Would something like this be acceptable?
> ---
> From 15502168009b7b5ae2b46d854c461e5ad031cdc6 Mon Sep 17 00:00:00 2001
> From: Igor Mammedov <address@hidden>
> Date: Wed, 27 Mar 2013 14:21:20 +0100
> Subject: [PATCH] cpu: Pass CPUState to *cpu_synchronize_post*()
> 
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>  cpus.c               |  4 ++--
>  include/sysemu/kvm.h | 12 ++++++------
>  kvm-all.c            |  8 ++------
>  kvm-stub.c           |  4 ++--
>  4 files changed, 12 insertions(+), 16 deletions(-)

Looks good so far, did you grep for further occurrences?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg