Re: [Qemu-devel] [PATCH V14 5/5] VMXNET3 device implementation

[Paolo Bonzini]

Il 27/03/2013 15:49, Alexander Graf ha scritto:
>> > +#if defined(HOST_WORDS_BIGENDIAN)
>> > +#define const_cpu_to_le64(x) bswap_64(x)
>> > +#define __BIG_ENDIAN_BITFIELD
> Ah, sorry, I replied to the wrong version.
> 
> ARE YOU KIDDING ME? BIG ENDIAN BITFIELD? BITFIELDS ARE _IMPLEMENTATION 
> SPECIFIC_!
> 
> Can we please revert this whole patch set and send the authors back to school?

Can we please maintain a decent tone?

First, this file comes from Linux.  __BIG_ENDIAN_BITFIELD is a Linux
#define.  No doubt it is wrong to define it based on
HOST_WORDS_BIGENDIAN, it is better to use a configure check.  But it's
not the reason why PPC compilation fails.

Second, you haven't said _how_ it breaks PPC compilation.  Just
cut-and-paste from the compiler is enough.  Ok, I can guess it but not
always.

Third, there is no need to revert the patch set.  The const_cpu_to_le64
should simply be removed, since little-endian conversion is already done
in vmw_shmem_ld32.

Paolo