[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V10 17/17] hmp: add parameter device and -b for
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH V10 17/17] hmp: add parameter device and -b for info block |
Date: |
Thu, 28 Mar 2013 12:09:37 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 22.03.2013 um 15:19 hat Wenchao Xia geschrieben:
> With these parameters, user can choose the information to be showed,
> to avoid message flood in the montior.
>
> Signed-off-by: Wenchao Xia <address@hidden>
Aha, so here you actually introduce the 'device' parameter. If you can
have this patch first, and only then patch 16, then limiting the new
output to the form with a device specified should be trivial.
> --- a/monitor.c
> +++ b/monitor.c
> @@ -2455,9 +2455,10 @@ static mon_cmd_t info_cmds[] = {
> },
> {
> .name = "block",
> - .args_type = "",
> - .params = "",
> - .help = "show the block devices",
> + .args_type = "backing:-b,device:B?",
> + .params = "[-b] [device]",
> + .help = "show info of one block device or all block devices "
> + "[and info of backing images with -b option",
That '[' doesn't look intentional?
Kevin
- [Qemu-devel] [PATCH V10 11/17] qmp: add ImageInfo in BlockDeviceInfo used by query-block, (continued)
- [Qemu-devel] [PATCH V10 11/17] qmp: add ImageInfo in BlockDeviceInfo used by query-block, Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 12/17] hmp: add function hmp_info_snapshots(), Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 13/17] hmp: switch snapshot info function to qmp based one, Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 14/17] block: move dump_human_image_info() to block/qapi.c, Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 15/17] block: dump to buffer for bdrv_image_info_dump(), Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 16/17] hmp: show ImageInfo in 'info block', Wenchao Xia, 2013/03/22
- [Qemu-devel] [PATCH V10 17/17] hmp: add parameter device and -b for info block, Wenchao Xia, 2013/03/22
- Re: [Qemu-devel] [PATCH V10 17/17] hmp: add parameter device and -b for info block,
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH V10 00/17] qmp/hmp interfaces for internal snapshot info, Kevin Wolf, 2013/03/28