[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 4/5] milkymist-softusb: Don't map RAM memory
From: |
Michael Walle |
Subject: |
Re: [Qemu-devel] [PATCH v3 4/5] milkymist-softusb: Don't map RAM memory regions in the device itself |
Date: |
Thu, 28 Mar 2013 19:31:21 +0100 |
User-agent: |
KMail/1.13.5 (Linux/2.6.32-5-686-bigmem; KDE/4.4.5; i686; ; ) |
Am Donnerstag 28 März 2013, 18:55:59 schrieb Anthony Liguori:
> Peter Maydell <address@hidden> writes:
> > Don't map the pmem and dmem RAM memory regions in the milkymist-softusb
> > device itself. Instead just expose them as sysbus mmio regions which
> > the device creator can map appropriately. This allows us to drop the
> > pmem_base and dmem_base properties. Instead of going via
> > cpu_physical_memory_read/_write when the device wants to access the
> > RAMs, we just keep a host pointer to the memory and use that.
> >
> > Signed-off-by: Peter Maydell <address@hidden>
> > Reviewed-by: Andreas Färber <address@hidden>
> > Acked-by: Michael Walle <address@hidden>
>
> Breaks the build:
>
> address@hidden qemu]$ make
> CC lm32-softmmu/hw/lm32/../milkymist-softusb.o
> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c: In function
> ‘softusb_mouse_hid_datain’:
> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:183:38: error: ‘m’
> may be used uninitialized in this function [-Werror=maybe-uninitialized]
> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:179:13: note: ‘m’
> was declared here /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:
> In function ‘softusb_kbd_hid_datain’:
> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:197:38: error: ‘m’
> may be used uninitialized in this function [-Werror=maybe-uninitialized]
> /home/aliguori/git/qemu/hw/lm32/../milkymist-softusb.c:193:13: note: ‘m’
> was declared here cc1: all warnings being treated as errors
> make[1]: *** [hw/lm32/../milkymist-softusb.o] Error 1
are you sure, this patch breaks the build, or was is broken before?
i'll send a patch soon.
--
michael
[Qemu-devel] [PATCH v3 5/5] sysbus: Remove sysbus_add_memory and sysbus_del_memory, Peter Maydell, 2013/03/15
[Qemu-devel] [PATCH v3 3/5] milkymist-minimac2: Just expose buffers as a sysbus mmio region, Peter Maydell, 2013/03/15
[Qemu-devel] [PATCH v3 2/5] musicpal: qdevify musicpal-misc, Peter Maydell, 2013/03/15
Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory, Paolo Bonzini, 2013/03/15
Re: [Qemu-devel] [PATCH v3 0/5] Remove sysbus_add_memory and sysbus_del_memory, Peter Maydell, 2013/03/28