[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Patch] fix /proc/self/maps output
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [Patch] fix /proc/self/maps output |
Date: |
Fri, 29 Mar 2013 09:18:45 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
On 03/29/2013 09:13 AM, Christophe Lyon wrote:
> Hi,
>
> Sorry I wasn't aware of such restrictions (I'm used to gcc/binutils
> conventions), and my thunderbird does display my patch as if it were
> inline :-)
> So.... trying a cut-and-paste approach in gmail, for this one character patch:
Still not ideal. The commentary above should not be part of the final
commit message, so you should move it...
>
>
> /proc/self/maps: Add a space at end of line when there is no filename
> to print, to conform to linux kernel format.
>
> Signed-off-by: Christophe Lyon <address@hidden>
...here, after a --- line that tells 'git am' where to stop reading
commit message. 'git send-email' is your friend. Then whether or not
you use 'git send-email', it is always wise to test if your patch is
usable by first sending it to yourself, and seeing if 'git am' will do
the right thing with it.
http://wiki.qemu.org/Contribute/SubmitAPatch has more hints.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature