Re: [Qemu-devel] [Patch] fix /proc/self/maps output

[H. Peter Anvin]

On 03/29/2013 09:01 AM, Christophe Lyon wrote:
> Add a space at end of line when there is no filename to print, to
> conform to linux kernel format.
> 
> Signed-off-by: Christophe Lyon <address@hidden>
> ---
>  linux-user/syscall.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a148d9f..3b0ca86 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -5016,7 +5016,7 @@ static int open_self_maps(void *cpu_env, int fd)
>                      " %c%c%c%c %08" PRIx64 " %02x:%02x %d%s%s\n",
>                      h2g(min), h2g(max), flag_r, flag_w,
>                      flag_x, flag_p, offset, dev_maj, dev_min, inode,
> -                    path[0] ? "          " : "", path);
> +                    path[0] ? "          " : " ", path);
>          }
>      }
> 

Please move the fixed space into the format.  Perhaps even use a %-123s
type format even...

        -hpa