[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] tweak lookup_feature() in target-i386/cpu.c
From: |
Michael W. Bombardieri |
Subject: |
[Qemu-devel] [PATCH] tweak lookup_feature() in target-i386/cpu.c |
Date: |
Sat, 30 Mar 2013 10:01:21 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Hi,
The following patch removes variable 'found' from lookup_feature().
We can just return true/false (found/not found) directly.
Does this look OK?
- Michael
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index a0640db..9147aaf 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -319,15 +319,14 @@ static bool lookup_feature(uint32_t *pval, const char *s,
const char *e,
{
uint32_t mask;
const char **ppc;
- bool found = false;
for (mask = 1, ppc = featureset; mask; mask <<= 1, ++ppc) {
if (*ppc && !altcmp(s, e, *ppc)) {
*pval |= mask;
- found = true;
+ return true;
}
}
- return found;
+ return false;
}
static void add_flagname_to_bitmaps(const char *flagname,
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [PATCH] tweak lookup_feature() in target-i386/cpu.c,
Michael W. Bombardieri <=